iemejia commented on pull request #13061:
URL: https://github.com/apache/beam/pull/13061#issuecomment-723113493


   @echauchot The VR tests were breaking on this (I don't know why, maybe the 
tests were improved). That's the reason why Luke did this PR, it was needed at 
least for correctness. You can reproduce this by reverting this PR and running 
the tests:
   
   ```
   git revert 6264b47afd51d33d95d6c04a2106b4208a89ca41
   ./gradlew :runners:spark:validatesStructuredStreamingRunnerBatch
   ```
   produces
   ```
   org.apache.beam.sdk.transforms.CombineTest$WindowingTests > 
testSlidingWindowsCombine FAILED
       java.lang.AssertionError at CombineTest.java:1156
           Caused by: java.lang.AssertionError at MatcherAssert.java:18
   ```
   
   Something odd I noticed is that if you run the single test instance it 
passes so I am not sure if there is some interleaving issue with other tests.
   
   The VR suite of the Structured Streaming Runner has been broken since 
September 10 also because of BEAM-11023
   
http://104.154.241.245/d/8N6LVeCmk/post-commits-status-dashboard?refresh=30s&orgId=1
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to