dengpanyin commented on a change in pull request #13280:
URL: https://github.com/apache/beam/pull/13280#discussion_r519029149
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/KeyedTimerData.java
##########
@@ -192,7 +193,10 @@ public void encode(KeyedTimerData<K> value, OutputStream
outStream)
keyBytes = baos.toByteArray();
}
- return new KeyedTimerData(keyBytes, key, timer);
+ final String timerFamilyId = inStream.available() > 0 ?
STRING_CODER.decode(inStream) : "";
Review comment:
Can you add a comment saying all new fields must be append to the end in
order not to break forward/backward compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
