lostluck commented on a change in pull request #13272:
URL: https://github.com/apache/beam/pull/13272#discussion_r520070443
##########
File path: sdks/go/pkg/beam/core/monitoring/monitoring.go
##########
@@ -13,10 +13,12 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-package harness
+package monitoring
Review comment:
That said, doing the inverse: Having the new metricx package have
Exported payload encoding helpers, and have the harness specific monitoring
code depend on those, would be a good move, if you don't like the copying.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
