kennknowles commented on pull request #13285: URL: https://github.com/apache/beam/pull/13285#issuecomment-724287465
This test is simple and makes sense. I thought we already had some of these so I am surprised to see this. Perhaps they are in `ParDoTest` or are just unit tests of the pushback side input DoFnRunner (and I would agree that is not good enough and they should be `ValidatesRunner` tests). Or perhaps my memory is wrong. Noting that `UsesTestStream` tests are disabled: https://github.com/apache/beam/blob/550ea9fc4db38f543350350fcc0734029a587e81/runners/google-cloud-dataflow-java/build.gradle#L167 LGTM but to get this running we might need to alter that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
