TheNeuralBit commented on a change in pull request #13148:
URL: https://github.com/apache/beam/pull/13148#discussion_r520891393
##########
File path: gradle/wrapper/gradle-wrapper.properties
##########
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-bin.zip
Review comment:
Is there a reason we were using -all before? AFAICT it looks like the
difference is -all includes docs and source code, which we should be fine
without
##########
File path: gradle.properties
##########
@@ -19,6 +19,7 @@ org.gradle.caching=true
org.gradle.parallel=true
org.gradle.configureondemand=true
org.gradle.jvmargs=-Xss10240k
+org.gradle.vfs.watch=true
Review comment:
I'm a little wary of this. The [blog
post](https://blog.gradle.org/introducing-file-system-watching) does say its
ready for production use... but I'm wondering if we should just let individuals
try it themselves until it's enabled by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
