tysonjh commented on a change in pull request #13282:
URL: https://github.com/apache/beam/pull/13282#discussion_r521647285
##########
File path:
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java
##########
@@ -115,16 +116,55 @@ public static void setup() throws IOException {
.get();
}
+ @Test
+ public void testKafkaIOWithRunnerV2() throws IOException {
Review comment:
Instead of naming the test after the runner, is it possible to name the
test after the behavior that is being tested and use the configuration to
ensure it runs on the appropriate runners? Is there a reason to have both this
test and `testKafkaReadsAndWritesProperly`?
If so, it would be good to understand the difference through the test
naming. From what I can tell the material difference is that this test uses a
streaming pipeline to read where `testKafkaReadsAndWritesProperly` uses a batch
one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
