piotr-szuberski commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r523163048
##########
File path: sdks/java/io/kafka/build.gradle
##########
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile library.java.powermock
testCompile library.java.powermock_mockito
+ testCompile library.java.testcontainers_kafka
testRuntimeOnly library.java.slf4j_jdk14
testRuntimeOnly project(path: ":runners:direct-java", configuration:
"shadow")
- kafkaVersion210 "org.apache.kafka:kafka-clients:2.1.0"
+ kafkaVersions.each {"kafkaVersion$it.key"
"org.apache.kafka:kafka-clients:$it.value"}
Review comment:
It should do the same what kafkaVersion210 did. I've imported KafkaIO
2.25 jar and I can't see kafka-clients 2.1.0 in the dependencies.
I'm not sure how to import a jar to Gradle locally, I will try it out on
Monday.
##########
File path: sdks/java/io/kafka/build.gradle
##########
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile library.java.powermock
testCompile library.java.powermock_mockito
+ testCompile library.java.testcontainers_kafka
testRuntimeOnly library.java.slf4j_jdk14
testRuntimeOnly project(path: ":runners:direct-java", configuration:
"shadow")
- kafkaVersion210 "org.apache.kafka:kafka-clients:2.1.0"
+ kafkaVersions.each {"kafkaVersion$it.key"
"org.apache.kafka:kafka-clients:$it.value"}
Review comment:
It should do the same what kafkaVersion210 did. I've imported KafkaIO
2.25 jar and I can't see kafka-clients 2.1.0 in the dependencies. So I don't
think so.
I'm not sure how to import a jar to Gradle locally, I will try it out on
Monday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
