TheNeuralBit commented on a change in pull request #13128:
URL: https://github.com/apache/beam/pull/13128#discussion_r523294633
##########
File path: website/www/site/content/en/get-started/quickstart-java.md
##########
@@ -283,7 +283,7 @@ We are working on adding the instruction for this runner!
{{< highlight class="runner-spark" >}}
$ gradle clean execute -DmainClass=org.apache.beam.examples.WordCount \
- -Dexec.args="--inputFile=pom.xml --output=counts" -Pspark-runner
+ -Dexec.args="--inputFile=sample.txt --output=counts" -Pspark-runner
Review comment:
I think we should hold off updating the website until a beam release has
gone out with the change to add the sample file. The website is published
regularly, so if we update it now the quickstart will start telling users to do
this with 2.25 and it won't work.
##########
File path: sdks/java/maven-archetypes/examples/sample.txt
##########
@@ -0,0 +1,117 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
Review comment:
Is it correct to put a license header on this? I think this might
qualify for excluding from the RAT checker (I'm assuming we have an allow list
somewhere)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
