piotr-szuberski commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524267637
##########
File path: sdks/java/io/kafka/build.gradle
##########
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile library.java.powermock
testCompile library.java.powermock_mockito
+ testCompile library.java.testcontainers_kafka
testRuntimeOnly library.java.slf4j_jdk14
testRuntimeOnly project(path: ":runners:direct-java", configuration:
"shadow")
- kafkaVersion210 "org.apache.kafka:kafka-clients:2.1.0"
+ kafkaVersions.each {"kafkaVersion$it.key"
"org.apache.kafka:kafka-clients:$it.value"}
}
-configurations.kafkaVersion210 {
- resolutionStrategy {
- force "org.apache.kafka:kafka-clients:2.1.0"
+kafkaVersions.each { kv ->
+ configurations."kafkaVersion$kv.key" {
+ resolutionStrategy {
+ force "org.apache.kafka:kafka-clients:$kv.value"
+ }
}
}
-task kafkaVersion210Test(type: Test) {
Review comment:
I'm not sure as well but I guess so. I'm having a difficulty with the
recently added Kafka streaming performance tests so I'm changing this PR to
WIP.
If I understand correctly these streaming tests can't be run on
DirectRunner? They never stop on both direct and flink even with `readTimeout`
set to 1min
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
