kmjung commented on a change in pull request #13378:
URL: https://github.com/apache/beam/pull/13378#discussion_r526467893
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java
##########
@@ -335,13 +341,15 @@ public synchronized void close() {
+ "the left of the split fraction {}.",
source.readStream.getName(),
fraction);
+ splitPossible = false;
return null;
} catch (Exception e) {
Metrics.counter(
BigQueryStorageStreamReader.class,
"split-at-fraction-calls-failed-due-to-other-reasons")
.inc();
LOG.error("BigQuery Storage API stream split failed.", e);
+ splitPossible = false;
Review comment:
Same comment here.
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java
##########
@@ -335,13 +341,15 @@ public synchronized void close() {
+ "the left of the split fraction {}.",
source.readStream.getName(),
fraction);
+ splitPossible = false;
Review comment:
Nit: I don't think this is correct, or required. Once we've reached this
point, we know that the splitReadStream call above has in fact succeeded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
