kamilwu commented on a change in pull request #13362:
URL: https://github.com/apache/beam/pull/13362#discussion_r526761726
##########
File path: .test-infra/jenkins/CommonTestProperties.groovy
##########
@@ -21,17 +21,36 @@
class CommonTestProperties {
enum SDK {
PYTHON,
- JAVA
+ JAVA,
+ GO,
}
enum Runner {
- DATAFLOW("DataflowRunner"),
- TEST_DATAFLOW("TestDataflowRunner"),
- SPARK("SparkRunner"),
- SPARK_STRUCTURED_STREAMING("SparkStructuredStreamingRunner"),
- FLINK("FlinkRunner"),
- DIRECT("DirectRunner"),
- PORTABLE("PortableRunner")
+ DATAFLOW,
+ TEST_DATAFLOW,
+ SPARK,
+ SPARK_STRUCTURED_STREAMING,
+ FLINK,
+ DIRECT,
+ PORTABLE,
+
+ def runnerNames = [
+ DATAFLOW: "DataflowRunner",
+ TEST_DATAFLOW: "TestDataflowRunner",
+ SPARK: "SparkRunner",
+ SPARK_STRUCTURED_STREAMING: "SparkStructuredStreamingRunner",
+ FLINK: "FlinkRunner",
+ DIRECT: "DirectRunner",
+ PORTABLE: "PortableRunner",
+ ]
+
+ def goRunnerNames = [
+ DATAFLOW: "dataflow",
+ SPARK: "spark",
+ FLINK: "flink",
+ DIRECT: "direct",
+ PORTABLE: "universal",
Review comment:
I think it's worth doing it now. That will make a big part of infra
changes unnecessary. I personally prefer the second option, which registers
additional alias in the same package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
