kennknowles commented on a change in pull request #13372:
URL: https://github.com/apache/beam/pull/13372#discussion_r527059681
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -358,26 +359,19 @@ task validatesRunnerV2 {
dependsOn(createRunnerV2ValidatesRunnerTest(
name: 'validatesRunnerV2Test',
excludedCategories: [
- 'org.apache.beam.sdk.testing.UsesRequiresTimeSortedInput',
+ 'org.apache.beam.sdk.testing.UsesUnboundedSplittableParDo',
Review comment:
Exclude UsesUnboundedPCollection here?
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java
##########
@@ -304,6 +305,7 @@ public void testOutputAfterCheckpointBounded() {
@Test
@Category({ValidatesRunner.class, UsesUnboundedSplittableParDo.class})
public void testOutputAfterCheckpointUnbounded() {
+ p.getOptions().as(TestPipelineOptions.class).setTestTimeoutSeconds(900L);
Review comment:
This value is runner-specific. For many configurations a much smaller
number is appropriate. This number is probably safe for all runners so it OK.
But can you set it in the gradle file to some large number that will work for
all the ValidatesRunner tests? Probably 900 is safe for any of them since they
are small compliance tests and none are high load.
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -418,10 +412,6 @@ task validatesRunnerV2Streaming {
name: 'validatesRunnerV2TestStreaming',
pipelineOptions: runnerV2PipelineOptions + ['--streaming=true'],
excludedCategories: [
- // Not supported in Dataflow streaming mode.
- 'org.apache.beam.sdk.testing.UsesRequiresTimeSortedInput',
Review comment:
This I am confused about. I did not think that Dataflow supported
requiring time-sorted input in streaming either runner v1 or v2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
