emilymye commented on a change in pull request #13393: URL: https://github.com/apache/beam/pull/13393#discussion_r527601696
########## File path: .test-infra/jenkins/job_Publish_SDK_Image_Snapshots.groovy ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as commonJobProperties + +// This job publishes regular snapshots of the SDK harness containers for +// testing purposes. It builds and pushes the SDK container to the +// specified GCR repo, tagged at the current Git commit. +job('beam_Publish_Beam_SDK_Snapshots') { + description('Builds SDK harness images snapshots regularly for testing purposes.') + + // Set common parameters. + commonJobProperties.setTopLevelMainJobProperties(delegate) + + // // Runs once per hour. + commonJobProperties.setAutoJob(delegate, '0 * * * *') Review comment: Our current plan is to use the associated commit with the latest snapshot for Beam imports - we'd rather not keep them nightly, but perhaps every hour is excessive? ########## File path: .test-infra/jenkins/job_Publish_SDK_Image_Snapshots.groovy ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as commonJobProperties + +// This job publishes regular snapshots of the SDK harness containers for +// testing purposes. It builds and pushes the SDK container to the +// specified GCR repo, tagged at the current Git commit. +job('beam_Publish_Beam_SDK_Snapshots') { + description('Builds SDK harness images snapshots regularly for testing purposes.') + + // Set common parameters. + commonJobProperties.setTopLevelMainJobProperties(delegate) + + // // Runs once per hour. + commonJobProperties.setAutoJob(delegate, '0 * * * *') + + // Use jenkins env var interpolation - leave in single quotes + def imageRepo = 'gcr.io/apache-beam-testing/beam-sdk' + def imageTag = '${GIT_COMMIT}' Review comment: If there is a better place to pull this in, please let me know! ########## File path: .test-infra/jenkins/job_Publish_SDK_Image_Snapshots.groovy ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as commonJobProperties + +// This job publishes regular snapshots of the SDK harness containers for +// testing purposes. It builds and pushes the SDK container to the +// specified GCR repo, tagged at the current Git commit. +job('beam_Publish_Beam_SDK_Snapshots') { + description('Builds SDK harness images snapshots regularly for testing purposes.') + + // Set common parameters. + commonJobProperties.setTopLevelMainJobProperties(delegate) + + // // Runs once per hour. + commonJobProperties.setAutoJob(delegate, '0 * * * *') + + // Use jenkins env var interpolation - leave in single quotes + def imageRepo = 'gcr.io/apache-beam-testing/beam-sdk' + def imageTag = '${GIT_COMMIT}' Review comment: I also wonder if we should error if not running against master - it would make sense to at least tag it differently or place non-master in a different repository folder so a PR-created snapshot can't replace a valid master snapshot as a latest tag. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
