nikie commented on a change in pull request #13350:
URL: https://github.com/apache/beam/pull/13350#discussion_r528393127
##########
File path: sdks/python/apache_beam/io/mongodbio.py
##########
@@ -241,6 +275,27 @@ def _get_split_keys(self, desired_chunk_size_in_mb,
start_pos, end_pos):
max={'_id': end_pos},
maxChunkSize=desired_chunk_size_in_mb)['splitKeys'])
+ def _get_buckets(self, desired_chunk_size, start_pos, end_pos):
+ if start_pos >= end_pos:
+ # single document not splittable
+ return []
+ size = self.estimate_size()
+ bucket_count = size // desired_chunk_size
+ if size % desired_chunk_size != 0:
+ bucket_count += 1
+ with beam.io.mongodbio.MongoClient(self.uri, **self.spec) as client:
+ buckets = list(
Review comment:
Fixed - return buckets cover all the requested range.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
