nielsbasjes commented on pull request #12837:
URL: https://github.com/apache/beam/pull/12837#issuecomment-732070136


   So I cloned your repo and checkout the devDocker branch.
   Then `docker build -t devdocker:20201123 .`
   After this image was built I did as you indicated `docker run -it 
--network=host -v /var/run/docker.sock:/var/run/docker.sock --mount 
type=bind,source="$PWD",target=/workspaces/beam devdocker:20201123 bash`
   Then (as indicated on https://beam.apache.org/contribute/ ) I run `./gradlew 
check`
   
   Now I the problem I had indeed does not occur (good!) yet I did run into 
some other problems.
   
   Some things I found while comparing your setup and mine
   - Yours works better for the Java stuff
   - Several of the website tasks fail.
   - Big difference in the installed tools.
     - Yours is missing gcc (needed for :sdks:java:container:goVet )
     - You install `docker-ce` (manually pulling in the repo) where I install 
the ubuntu native `docker-io`. Which is better?
   
   In addition I think the scripting my version has is really a `must have` as 
I found that the `.gradle` directory is owned by `root`.
   
   So I propose to make a combination of your image (+gcc) and my scripting to 
create something people can easily use.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to