emilymye commented on pull request #13374:
URL: https://github.com/apache/beam/pull/13374#issuecomment-732358628


   R: @TheNeuralBit 
   R: @kennknowles 
   
   After some investigation, I think this is actually the more reliable way 
created to run Java 11 tests against Java 8 Beam (based on conversation from an 
old [PR](https://github.com/apache/beam/pull/11113) - the WIPs mentioned there 
are closed PRs but the actual code was 
[committed](https://github.com/apache/beam/commit/cecc4db31322c9071f3c0e894b03f070e4a6340a)
 later on. We should go back and fix tests in either case.
   
   To test locally, I ran 
   ```
   ./gradlew 
:runners:google-cloud-dataflow-java:examplesJavaRunnerV2IntegrationTest 
     -PdisableSpotlessCheck=true
     -PcompileAndRunTestsWithJava11
     -PskipCheckerFramework
     -Pjava11Home=...
     -PdataflowProject="..."
     -PdataflowTempRoot="..."
     -PdockerImageRoot="..."
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to