TheNeuralBit commented on pull request #13401: URL: https://github.com/apache/beam/pull/13401#issuecomment-732390090
So making `Index.check` more aggressive caused a new class of failures - expressions with `preserves=partitionings.Index` with a Singleton partitioned input should produce an output partitioned by Index, but usually actually produce a Singleton partitioned output. I'm having a hard time reasoning about this.. but it seems like maybe `preserves=partitionings.Index` should not be allowed (or used very rarely) as none of these expressions respect this property when the input is Singleton. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
