mxm commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r530227909
##########
File path: gradle.properties
##########
@@ -31,3 +31,6 @@ javaVersion=1.8
docker_image_default_repo_root=apache
docker_image_default_repo_prefix=beam_
+
+org.gradle.daemon=false
Review comment:
Why disable the daemon?
##########
File path: runners/flink/1.11/build.gradle
##########
@@ -17,6 +17,10 @@
*/
def basePath = '..'
+def flink_clients_version = "1.11.1"
+def flink_annotations_version = "1.11.1"
+def flink_optimizer_version = "1.11.1"
Review comment:
Same here, one version variable is enough. Would be good to infer it
from the Flink project files.
##########
File path: runners/flink/1.8/job-server/build.gradle
##########
@@ -29,3 +29,8 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.8")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Could we move those into `flink_job_server.gradle`?
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,10 @@
*/
def basePath = '..'
+def flink_clients_version = "1.10.1"
+def flink_annotations_version = "1.10.1"
+def flink_optimizer_version = "1.10.1"
Review comment:
This should just be `flink_version`, no need to break this down into
separate version as different versions are generally not compatible with each
other.
##########
File path: runners/flink/1.11/job-server/build.gradle
##########
@@ -29,3 +29,9 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.11")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Same here.
##########
File path: runners/flink/1.9/job-server/build.gradle
##########
@@ -29,3 +29,8 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.9")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Same here.
##########
File path: runners/flink/1.8/build.gradle
##########
@@ -32,3 +35,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared library.java.jackson_annotations
+ permitUnusedDeclared
"org.apache.flink:flink-clients_2.11:$flink_clients_version"
+ compile library.java.jackson_databind
+ compile library.java.jsr305
+ compile "org.apache.flink:flink-annotations:$flink_annotations_version"
+ compile "org.apache.flink:flink-optimizer_2.11:$flink_optimizer_version"
+ compile "org.checkerframework:checker-qual:$checker_qual_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf",
configuration: "shadow")
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Could we move those into `flink_runner.gradle`?
##########
File path: runners/flink/1.11/build.gradle
##########
@@ -31,3 +35,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared library.java.jackson_annotations
+ permitUnusedDeclared
"org.apache.flink:flink-clients_2.11:$flink_clients_version"
Review comment:
This could be true because we often submit only against embedded
clusters. However, if you look at `FlinkSubmissionTest`, it definitely utilizes
the client dependency through the use of Clifrontend (part of flink-clients).
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -17,6 +17,10 @@
*/
def basePath = '..'
+def flink_clients_version = "1.10.1"
+def flink_annotations_version = "1.10.1"
+def flink_optimizer_version = "1.10.1"
Review comment:
Would be good to infer the version from the Flink project files.
##########
File path: runners/flink/1.10/build.gradle
##########
@@ -31,3 +35,19 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_runner.gradle"
+
+dependencies {
+ permitUnusedDeclared library.java.jackson_annotations
Review comment:
Would be good if shared dependencies across different Flink versions
would remain in `flink_runner.gradle`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
