robertwb commented on pull request #13431: URL: https://github.com/apache/beam/pull/13431#issuecomment-734006158
Yes, this is more similar to Java. Good point about doing this for the watermark provider too--I'll do that. (Removing the old way would be backwards incompatible and a more invasive change.) On Wed, Nov 25, 2020 at 4:20 PM Boyuan Zhang <[email protected]> wrote: > It seems like we want to do the similar thing to java? Java SDK uses DoFn > as both RestrictionProvider and WatemarkEstimatorProvider. If so, it > would be better for python sdk to either do the same thing as java sdk or > keep using RestrictionTracker and WatermarkEstimatorProvider classes. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/13431#issuecomment-734004182>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADWVAJXBI64PMALKQCNTF3SRWNORANCNFSM4UDA4RDQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
