ajamato commented on pull request #13308: URL: https://github.com/apache/beam/pull/13308#issuecomment-736822640
> Thanks @nielsbasjes! I looked this over and I have a few minor suggestions. > > @ajamato, @rohdesamuel - would you be willing to try this out and see if it works for your purposes? Okay > > Thanks @nielsbasjes! I looked this over and I have a few minor suggestions. > > @ajamato, @rohdesamuel - would you be willing to try this out and see if it works for your purposes? > > I'll give it a try @rohdesamuel FYI you can use this to pull in the PR > > git fetch origin pull/13308/head:[BEAM-10891](https://issues.apache.org/jira/browse/BEAM-10891)-Development-Docker > > git checkout [BEAM-10891](https://issues.apache.org/jira/browse/BEAM-10891)-Development-Docker > > (assumes origin is set to apache beam git repo) Okay. I gave it a try. And in its current state, IMO I wouldn't use it, it would be too complicated to use compare to what I have now. I was basically just aiming to go through the commands here, run the python tests, run the lint, format steps, etc. And make sure they all work https://cwiki.apache.org/confluence/display/BEAM/Python+Tips First I couldn't run pyenv, to setup a virutalenv and perform the steps in that guide. We would need to install pyenv pyenv-virtualenv Then I would be able to setup a python virtualenv and perform the steps in the wiki Even better, I would like to see this setup a the docker container setup a python virtualenv as well. I think everything can run from within there. I didn't really attempt steps for java though ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
