TheNeuralBit commented on a change in pull request #13453:
URL: https://github.com/apache/beam/pull/13453#discussion_r533737969
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1041,6 +1041,10 @@ class BeamModulePlugin implements Plugin<Project> {
}
testCompile.extendsFrom shadowTest
}
+
+ project.tasks.named('build').configure {
Review comment:
nit: it would be good to have a comment justifying this, something like:
```suggestion
// Ensure build task depends on shadowJar (required for shadow
plugin >=4.0.4)
project.tasks.named('build').configure {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
