TheNeuralBit commented on a change in pull request #13464:
URL: https://github.com/apache/beam/pull/13464#discussion_r535734866
##########
File path: build.gradle
##########
@@ -375,8 +375,16 @@ if (project.hasProperty('compileAndRunTestsWithJava11')) {
project.sqlPreCommit.dependsOn
':sdks:java:testing:test-utils:verifyJavaVersion'
} else {
allprojects {
- tasks.withType(Test) {
+ tasks.withType(Test).configureEach {
exclude '**/JvmVerification.class'
}
}
}
+
+allprojects {
Review comment:
nit:
```suggestion
# Ignore sdk.properties so it doesn't spoil the build cache unnecessarily
(see
https://docs.gradle.org/6.6/userguide/more_about_tasks.html#sec:configure_input_normalization)
allprojects {
```
(or something)
##########
File path: sdks/java/core/build.gradle
##########
@@ -66,6 +66,10 @@ test {
}
}
+tasks.withType(Jar).configureEach {
+ preserveFileTimestamps(false)
+}
+
Review comment:
Could/should we do this in applyJavaNature and/or applyPortabilityNature
to get the benefit for all built jars?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
