nehsyc commented on a change in pull request #13405:
URL: https://github.com/apache/beam/pull/13405#discussion_r535772184
##########
File path: sdks/python/apache_beam/runners/dataflow/ptransform_overrides.py
##########
@@ -329,3 +330,44 @@ def expand(self, pcoll):
return {key: out for key in self.outputs}
return WriteToBigQuery(ptransform, self.outputs)
+
+
+class GroupIntoBatchesWithShardedKeyPTransformOverride(PTransformOverride):
+ """A ``PTransformOverride`` for ``GroupIntoBatches.WithShardedKey``.
+
+ This override simply returns the original transform but additionally records
+ the output PCollection in order to append required step properties during
+ graph translation.
+ """
+ def __init__(self, dataflow_runner, options):
+ self.dataflow_runner = dataflow_runner
+ self.options = options
+
+ def matches(self, applied_ptransform):
+ # Imported here to avoid circular dependencies.
+ # pylint: disable=wrong-import-order, wrong-import-position
+ from apache_beam import util
+
+ transform = applied_ptransform.transform
+
+ if not isinstance(transform, util.GroupIntoBatches.WithShardedKey):
+ return False
+
+ # The replacement is only valid for portable Streaming Engine jobs.
+ standard_options = self.options.view_as(StandardOptions)
+ if not standard_options.streaming:
+ return False
+ google_cloud_options = self.options.view_as(GoogleCloudOptions)
+ if not google_cloud_options.enable_streaming_engine:
+ return False
+ experiments = self.options.view_as(DebugOptions).experiments or []
+ if 'beam_fn_api' not in experiments:
Review comment:
Good catch! Actually we should disable the feature when using
beam_fn_api without use_unified_worker (JRH). Updated the logic and tests
according in the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
