tvalentyn commented on a change in pull request #13399:
URL: https://github.com/apache/beam/pull/13399#discussion_r536343446
##########
File path: sdks/python/apache_beam/runners/portability/sdk_container_builder.py
##########
@@ -235,24 +235,26 @@ def invoke_docker_build_and_push(self,
container_image_name):
build.timeout = Duration().FromSeconds(seconds=1800)
now = time.time()
- _LOGGER.info(
- 'Building sdk container with google cloud build, this may '
- 'take a few minutes...')
operation = client.create_build(project_id=project_id, build=build)
- # if build fails exception will be raised and stops the job submission.
- try:
- result = operation.result()
- except Exception as e:
- build_lists = client.list_builds(
- project_id=project_id,
- filter="source.storage_source.bucket=\"%s\" AND source"
- ".storage_source.object=\"%s\"" % (gcs_bucket, gcs_object))
- for build in build_lists:
- _LOGGER.error("Build failed, check log at %s" % build.log_url)
- raise e
_LOGGER.info(
- "Python SDK container pre-build finished in %.2f seconds, "
- "check build log at %s" % (time.time() - now, result.log_url))
+ 'Building sdk container with google cloud build, this may '
+ 'take a few minutes...')
+ # TODO: we shouldn't need to query build log url with list_builds if log
Review comment:
Consider filing a feature request for the owner of this library.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
