dennisylyung commented on pull request #12583: URL: https://github.com/apache/beam/pull/12583#issuecomment-739135639
> My excuses @dennisylyung I took a quick look today and it looks mostly ok (I have some minor things that I can fix) the only issue I have is that I just realized that the tests are disabled for DynamoDB how did you get them to run? I removed the Ignore annotation and enabled the specific extra test on this PR but I get a failure. I tested also by commenting out the ignore annotation. The test itself passes, but `destroy` fails due to this bug https://github.com/localstack/localstack/issues/2702. The error is universal to all tests in DynamoDBIOTest, not just the new one. I upgraded Localstack to the fixed version and it now passes. (It always passes in aws2) @iemejia ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
