ilya-kozyrev commented on a change in pull request #13112: URL: https://github.com/apache/beam/pull/13112#discussion_r537802690
########## File path: examples/templates/java/kafka-to-pubsub/src/test/java/org/apache/beam/templates/KafkaToPubsubTest.java ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.templates; + +import static org.apache.beam.templates.KafkaPubsubConstants.PASSWORD; +import static org.apache.beam.templates.KafkaPubsubConstants.USERNAME; +import static org.apache.beam.templates.kafka.consumer.Utils.getKafkaCredentialsFromVault; + +import java.util.HashMap; +import java.util.Map; +import org.apache.beam.templates.kafka.consumer.Utils; +import org.apache.kafka.common.config.SaslConfigs; +import org.apache.kafka.common.security.scram.ScramMechanism; +import org.junit.Assert; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test of KafkaToPubsub. */ +@RunWith(JUnit4.class) +public class KafkaToPubsubTest { Review comment: Thank you for bringing up the requirement of the e2e tests, we understand the solution needs it. Our focus is to get this example available to the community and be able to collect any feedback from customers using this example in their scenarios and the approach to the examples. We propose to keep this PR scope, create a JIRA ticket (for [Kafka](https://issues.apache.org/jira/browse/BEAM-11410) and [Pub/Sub](https://issues.apache.org/jira/browse/BEAM-11411)) to extend this example with e2e tests, and set customer expectations on e2e testing in the [readme](https://github.com/apache/beam/pull/13112/commits/e8ca92d68646cec459d3ecd94b0efe7551699268) for this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
