ibzib commented on a change in pull request #13487:
URL: https://github.com/apache/beam/pull/13487#discussion_r537872923



##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -1176,6 +1176,12 @@ def _add_argparse_args(cls, parser):
         default=0,
         help='Port to use for artifact staging. 0 to use a '
         'dynamic port.')
+    parser.add_argument(
+        '--java_launcher',
+        default='java',
+        help='The Java Application Launcher executable file to use for '
+        'starting a Java job server. If unset, `java` from the '
+        'environment\'s $PATH is used.')

Review comment:
       That's a great question. Originally I was going to do both in this PR, 
but I reconsidered because expansion services and job servers are logically 
separate things (although job servers sometimes include expansion services). So 
I'll take your suggestion to rename, and we'll track the expansion service in 
BEAM-11414.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to