iemejia commented on pull request #12583: URL: https://github.com/apache/beam/pull/12583#issuecomment-740753739
Thanks a lot for the info on localstack if you feel motivated please open a PR to update localstack and enable the tests that work in that PR otherwise I will do. I am trying to understand this again because it seems I may have misinterpreted it before. If we need deduplication to guarantee that operations do not fail in the presence of duplicate attributes why we need to pass the overwrite keys explictly? With the current implementation I have the impression we could end up filtering also non repeated keys. Couldn't we just simply compare the current `private List<KV<String, WriteRequest>> batch;` with the current element and overwrite the duplicate element if is the case. I think this will make the implementation much simpler (and also won't change order). Also if deduplication is mandatory to not have `ValidationException` shouldn't this be the default behaviour? Or in which case I can benefit of avoiding deduplication? I excuse myself because I don't want to delay this longer but I still think I do not understand the fix. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
