dpcollins-google commented on a change in pull request #13470:
URL: https://github.com/apache/beam/pull/13470#discussion_r539514951
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteIO.java
##########
@@ -64,8 +64,8 @@ private PubsubLiteIO() {}
* .build()), "read");
* }</pre>
*/
- public static Read.Unbounded<SequencedMessage> read(SubscriberOptions
options) {
- return Read.from(new PubsubLiteUnboundedSource(options));
+ public static PTransform<PBegin, PCollection<SequencedMessage>>
read(SubscriberOptions options) {
Review comment:
I don't (it adds to the api surface for an uncommon case), but this can
be implemented in userland by:
```
PCollectionList list = PCollectionList.of();
for (SubscriptionPath subscription : subscriptions) {
list = list.and(p.apply(PubsubLiteIO.read(SubscriberOptions.newBuilder()
.setSubscriptionPath(subscriptionPath)
.build()), "read"));
}
return list.apply(Flatten.<SequencedMessage>pCollections())
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
