lostluck commented on a change in pull request #13505:
URL: https://github.com/apache/beam/pull/13505#discussion_r539571853
##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflowlib/execute.go
##########
@@ -122,3 +135,21 @@ func PrintJob(ctx context.Context, job *df.Job) {
}
log.Info(ctx, string(str))
}
+
+type dataflowPipelineResult struct {
+ JobID string
Review comment:
SGTM for JobID. Remember that in Go it's not necessary to return the
exact interface that's supported every time. If the dataflow results or the
flink results need different method sets, they can export different methods,
and just document what are available on a custom results interface, that can be
type asserted to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
