nehsyc commented on pull request #13493: URL: https://github.com/apache/beam/pull/13493#issuecomment-742795645
> > hmm seems like python 3.6 failed and complained about > > ``` > > File "/home/runner/work/beam/beam/sdks/python/target/.tox/py36/lib/python3.6/site-packages/apache_beam/transforms/util.py", line 803, in GroupIntoBatches > > ShardedKeyType[typehints.TypeVariable(K)], # type: ignore[misc] > > TypeError: 'type' object is not subscriptable > > ``` > > It looks like Python 3.6 doesn't support `__class_getitem__`, only 3.7+. Usually the docs state this but not in this case... > > I think using the metaclass is the only solution that works on all versions. Python is hard :\ Kept getting `inherit-non-class` error with `with_metaclass` imported from `future.utils` and ended up using `six.with_metaclass` instead. Also added some doc string for `ShardedKeyTypeConstraint`. All checks are passing now (finally!). It's ready to be merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
