lostluck commented on a change in pull request #13518: URL: https://github.com/apache/beam/pull/13518#discussion_r542950228
########## File path: sdks/go/test/integration/integration.go ########## @@ -0,0 +1,108 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Package integration provides functionality that needs to be shared between all +// integration tests. +package integration + +import ( + "fmt" + "regexp" + "testing" + + "github.com/apache/beam/sdks/go/pkg/beam/testing/ptest" +) + +// Filters for temporarily skipping integration tests. All filters are regex +// matchers that must match the full name of a test at the point where +// CheckFilters is called. Multiple tests can be skipped by using regex +// wildcards. (ex. "TestXLang_.*" filters all tests starting with TestXLang_) +// +// It is strongly recommended to include, TODOs, Jira issues, or just comments +// describing why tests are being skipped. + +// sickbay filters tests that fail due to Go SDK errors. These tests will not +// execute on any runners. +var sickbay = []string{ + // TODO(BEAM-11418): These tests are currently failing with the Go SDK. + "TestXLang_CoGroupBy", + "TestXLang_Multi", + "TestXLang_Partition", +} + +// Runner-specific test filters, for features that are not yet supported on +// specific runners. + +var directFilters = []string{ + // The direct runner does not yet support cross-language. + "TestXLang.*", +} + +var portableFilters = []string{} + +var flinkFilters = []string{} + +var sparkFilters = []string{} Review comment: We should consider (at some future time) to make these into flags, so they can be overridden as needed. https://pkg.go.dev/github.com/spf13/pflag#StringSlice Not super important as someone would still want to edit the default if they're trying to fix/resolve some of these. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
