piotr-szuberski commented on a change in pull request #13542:
URL: https://github.com/apache/beam/pull/13542#discussion_r544186235
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -177,16 +177,6 @@ task runPojoExample(type: JavaExec) {
args = ["--runner=DirectRunner"]
}
-// These tests become flaky when run in parallel at more than 3 threads so run
them in a separate task
-task runKafkaTableProviderIT(type: Test) {
- outputs.upToDateWhen { false }
- include '**/KafkaTableProvider*IT.class'
- maxParallelForks 2
- classpath =
project(":sdks:java:extensions:sql").sourceSets.test.runtimeClasspath
- testClassesDirs =
files(project(":sdks:java:extensions:sql").sourceSets.test.output.classesDirs)
- useJUnit { }
-}
-
Review comment:
I'll replace the inheritance with parameterized tests, there shouldn't
be need for a separate Kafka task. The same problem was with Pubsub IT tests so
the task would have to receive GCP credentials as well to be able to run these
as well.
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -177,16 +177,6 @@ task runPojoExample(type: JavaExec) {
args = ["--runner=DirectRunner"]
}
-// These tests become flaky when run in parallel at more than 3 threads so run
them in a separate task
-task runKafkaTableProviderIT(type: Test) {
- outputs.upToDateWhen { false }
- include '**/KafkaTableProvider*IT.class'
- maxParallelForks 2
- classpath =
project(":sdks:java:extensions:sql").sourceSets.test.runtimeClasspath
- testClassesDirs =
files(project(":sdks:java:extensions:sql").sourceSets.test.output.classesDirs)
- useJUnit { }
-}
-
Review comment:
I'll replace the inheritance with parameterized tests, then there
shouldn't be need for a separate Kafka task. The same problem was with Pubsub
IT tests so the task would have to receive GCP credentials as well to be able
to run these as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
