Romster commented on a change in pull request #13513:
URL: https://github.com/apache/beam/pull/13513#discussion_r544315668
##########
File path:
sdks/java/io/xml/src/main/java/org/apache/beam/sdk/io/xml/XmlSource.java
##########
@@ -281,7 +283,15 @@ private long getFirstOccurenceOfRecordElement(
break outer;
} else {
// Matching was unsuccessful. Reset the buffer to include bytes
read for the char.
- ByteBuffer newbuf = ByteBuffer.allocate(BUF_SIZE);
+ int bytesToWrite = buf.remaining() + charBytes.length;
Review comment:
It seems to be a pretty rare corner case, so people usually don't face
it.
But our service deals with lots of big XML files with different formats and
we see it several times a week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
