piotr-szuberski commented on a change in pull request #13572:
URL: https://github.com/apache/beam/pull/13572#discussion_r546372051
##########
File path:
sdks/java/io/thrift/src/main/java/org/apache/beam/sdk/io/thrift/ThriftSchema.java
##########
@@ -183,7 +184,12 @@ private Schema schemaFor(Class<?> targetClass) {
private Schema.Field beamField(FieldMetaData fieldDescriptor) {
try {
final FieldType type = beamType(fieldDescriptor.valueMetaData);
- return Schema.Field.nullable(fieldDescriptor.fieldName, type);
+ switch (fieldDescriptor.requirementType) {
Review comment:
Well. it's purely cosmetic, I agree that switch is more readable and
makes it clear that there are another options. I'd leave it as it is. Listing
all the remaining options is definitely redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
