sonam-vend commented on a change in pull request #13364:
URL: https://github.com/apache/beam/pull/13364#discussion_r547232375
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java
##########
@@ -426,11 +515,55 @@ public Long mergeAccumulators(Iterable<Long> accums) {
}
@Override
- public Long extractOutput(Long accum) {
+ public Long extractOutput(Long accumulator) {
if (this.isEmpty) {
return null;
}
- return accum;
+ return accumulator;
+ }
+ }
+
+ static CombineFn createLogicalAnd(Schema.FieldType fieldType) {
+ if (fieldType.getTypeName() == TypeName.BOOLEAN) {
+ return new LogicalAnd();
+ }
+ throw new UnsupportedOperationException(
+ String.format("[%s] is not supported in LOGICAL_AND", fieldType));
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
