boyuanzz commented on pull request #13592: URL: https://github.com/apache/beam/pull/13592#issuecomment-750427257
> Great, I think this covers pretty much all the topics. I have only one small concern left - because the key in cache is derived from structuralValue of RestrictionCoder, it uses SerializableCoder for encoding the source. That might not be 100% stable. I would prefer to generate a different identifier in `UnboundedSourceAsSDFWrapperFn.splitRestriction` for each split and then carry it along all calls to `trySplit`. But this might be viewed as minor concern. I would not worry about that too much since we are using `Source` + `CheckpointMark` as the restriction, as well as the cache key. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
