ccciudatu edited a comment on pull request #13572: URL: https://github.com/apache/beam/pull/13572#issuecomment-751235635
@piotr-szuberski @TheNeuralBit @chrlarsen Thanks for looking into this! I resolved merge conflicts for `CHANGES.md` and added the following cosmetics: - simplified generics, as the `extends Enum<..>` constraint is no longer needed - dedicated `mockTable` versions for proto/thrift in `KafkaTableProviderTest` - listed the `DEFAULT` and `OPTIONAL` "requiredness" types explicitly, falling through to default -- for self-documenting purposes and to eliminate the compiler warning for too few cases (@piotr-szuberski, I hope you're ok with this) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
