kgabryje commented on a change in pull request #13511:
URL: https://github.com/apache/beam/pull/13511#discussion_r549355143
##########
File path: website/www/site/assets/scss/_navbar-desktop.scss
##########
@@ -166,6 +166,12 @@
.navigation-bar-mobile {
display: block;
+ width: 100%;
+ height: 64px;
+ padding: 9px 25.4px 9px 13px;
Review comment:
I wonder if fractions of pixels, like 25.4, are necessary. Browsers
round it anyway
##########
File path: website/www/site/assets/scss/_global.sass
##########
@@ -29,9 +29,11 @@ body
&:not(.body--index)
.body__contained
+ @media (max-width: $ak-breakpoint-lg)
+ padding: 0
padding: 0 30px
max-width: 1280px
-
+
Review comment:
Could you set up some linter to clean such white spaces?
##########
File path: website/www/site/assets/scss/_navbar-mobile.sass
##########
@@ -16,16 +16,31 @@
*/
.navbar
- padding: 15px 0
-
+ padding: 0 !important
+ :before
+ display: none
+ ::after
+ display: none
.navbar-nav > li > a
text-transform: uppercase
-
+ .navbar-link
+ font-size: 16px;
+ font-weight: normal;
+ font-stretch: normal;
+ font-style: normal;
+ line-height: normal;
+ letter-spacing: normal
Review comment:
Are those `normal` styles necessary? Aren't those default values?
##########
File path: website/www/site/assets/scss/_table-wrapper.scss
##########
@@ -0,0 +1,103 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+ $padding:24px;
+.table-wrapper{
+ table{
+ @extend .table;
+ max-width: 853px;
+ }
+ th:nth-child(1) {
+ @media (max-width: $mobile){
+ padding-left:0 !important;
+ width: 115px;
+ }
+ padding-left: 67px+$padding !important;
+ width: 491px;
+ }
+ th:nth-child(2) {
+ @media (max-width: $mobile){
+ width: 111px;
+ }
+ width: 181px;
+ }
+ th{
+ padding: 14px 14px 17px 14px !important;
+ border: none !important;
+ border-bottom: 1px solid #ff6d05 !important;
+ letter-spacing: 2px;
+ line-height: normal !important;
+ }
+ td{
+ @media (max-width: $mobile){
+ padding: $padding/4 !important;
+ }
+ padding: $padding !important;
+ border-bottom: 1px solid rgba(255, 109, 5, 0.24);
+ div{
+ display: flex;
+ position: relative;
+ }
+ img, svg{
+ @media (max-width: $mobile){
+ display: none;
+ }
+ position: absolute;
+ top:50%;
+ transform: translateY(-60%);
+ }
+ p{
+ @media (max-width: $mobile){
+ margin:0;
+ }
+ margin-left: 67px;
+ font-size: 14px;
+ line-height: 1.57;
+ }
+ }
+ td:nth-child(3) {
+ @media (max-width: $mobile){
+ padding: $padding/3 !important;
+ padding-left: $padding/4 !important;
+ }
+ padding: $padding/3 !important;
+ padding-left: $padding !important;
+ div{
+ flex-direction: column;
+ }
+ a{
+ text-decoration: underline;
+ line-height: 2;
+ letter-spacing: 0.43px;
+ }
+ }
+ td:nth-child(2) {
+ background-color: rgba(255, 109, 0, 0.04);
+ padding-left: $padding/2 !important;
+ padding-right: 0 !important;
Review comment:
Could you try to get rid of those `!important`s here and in other
places? Maybe by adding some css class to increase specificity?
##########
File path: website/www/site/content/en/community/_index.md
##########
@@ -0,0 +1,28 @@
+---
+title: "Community Beam"
+aliases:
+ - /use/issue-tracking/
+ - /use/mailing-lists/
+ - /get-started/support/
+---
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+# Welcome to the Beam Community!
+</br>
Review comment:
Like we discussed, I think it would be a good idea to add some spacings
to headers and get rid of `<br />`s
##########
File path: website/www/site/layouts/shortcodes/table_with_icons.html
##########
@@ -0,0 +1,51 @@
+{{/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+*/}}
+{{ $data := index $.Site.Data .Site.Language.Lang }}
+
+<div class="table-wrapper">
+ <table>
+ <tr>
+ <th>PURPOSE</th>
+ <th>CONTACT</th>
+ <th>ACTION</th>
+ </tr>
+ {{ range $item := $data.contact_us }}
+ <tr>
+ <td>
+ <div>
+ {{ with resources.Get .icon }}
+ {{ .Content | safeHTML }}
+ {{ end }}
+ <p>{{.purpose | safeHTML}}</p>
Review comment:
Nit: Could you add spaces before and after curly braces for consistency?
Like `<p>{{ .purpose | safeHTML }}</p>`. Maybe there's some hugo linter
available that would help with that?
##########
File path: website/www/site/content/en/community/contact-us.md
##########
@@ -20,28 +20,34 @@ See the License for the specific language governing
permissions and
limitations under the License.
-->
-# Contact Us
+
+# Contact us!
+
+<br/>
There are many ways to reach the Beam user and developer communities - use
whichever one seems best.
-<!-- We use div instead of table shortcode here, because markdownify break
superscripts -->
-<div class="table-wrapper">
+<br/>
Review comment:
Same as above - it'd be great to replace those `<br />` tags
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
