kgabryje commented on a change in pull request #13596:
URL: https://github.com/apache/beam/pull/13596#discussion_r549370287
##########
File path: website/www/site/layouts/_default/baseof.html
##########
@@ -19,13 +19,13 @@
{{ partial "header.html" . }}
<div class="body__contained">
{{ block "hero-section" . }}{{ end }}
+ {{ block "ctas-section" . }}{{ end }}
{{ block "pillars-section" . }}{{ end }}
{{ block "graphic-section" . }}{{ end }}
{{ block "calendar-section" . }}{{ end }}
{{ block "quotes-section" . }}{{ end }}
Review comment:
Calendar and quotes sections behave a bit weirdly on smaller screen
##########
File path: website/www/site/data/en/documentation_runners.yaml
##########
@@ -0,0 +1,34 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- name: { text: "DirectRunner:", link: /documentation/runners/direct/ }
+ icon: icons/documentation/runners/beam-icon.svg
+ description: Runs locally on your machine – great for developing, testing,
and debugging.
+- name: { text: "FlinkRunner:", link: /documentation/runners/flink/ }
+ icon: icons/documentation/runners/flink-icon.svg
+ description: Runs on <a href="https://flink.apache.org";>Apache Flink</a>.
+- name: { text: "SparkRunner:", link: /documentation/runners/spark/ }
+ icon: icons/documentation/runners/spark-icon.svg
+ description: Runs on <a href="https://spark.apache.org";>Apache Spark</a>.
+- name: { text: "DataflowRunner:", link: /documentation/runners/dataflow/ }
+ icon: icons/documentation/runners/dataflow-icon.svg
+ description: Runs on <a href="https://cloud.google.com/dataflow";>Google
Cloud Dataflow</a>, a fully managed service within Google Cloud Platform.
+- name: { text: "SamzaRunner:", link: /documentation/runners/samza/ }
+ icon: icons/documentation/runners/samza-icon.svg
+ description: Runs on <a href="https://samza.apache.org";>Apache Samza</a>.
+- name: { text: "NemoRunner:", link: /documentation/runners/nemo/ }
+ icon: icons/documentation/runners/nemo-icon.svg
+ description: Runs on <a href="https://nemo.apache.org";>Apache Nemo</a>.
+- name: { text: "JetRunner:", link: /documentation/runners/jet/ }
+ description: Runs on <a href="https://jet.hazelcast.org/";>Hazelcast Jet</a>.
+- name: { text: "Twister2Runner:", link: /documentation/runners/twister2/ }
+ description: Runs on <a href="https://twister2.org/";>Twister2</a>.
Review comment:
I wonder if external links should open in new tabs?
##########
File path: website/www/site/layouts/shortcodes/documentation/runners.html
##########
@@ -0,0 +1,45 @@
+{{/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+ */}}
+
+ {{ $data := index $.Site.Data .Site.Language.Lang }}
+ <div class="documentation-list mobile-column">
+ {{ range first 6 ($item := $data.documentation_runners) }}
+ {{ if .icon }}
+ {{ partial "documentation/icon-row" (dict "logo" .icon
"header" .name "text" .description) }}
+ {{ else }}
+ {{ partial "documentation/icon-row" (dict "header" .name
"text" .description) }}
+ {{ end }}
+ {{ end }}
+ {{ if gt (len $data.documentation_runners) 6 }}
+ <div class="collapsable-list">
+ <div class="collapse" id="collapseExample">
+ <ul>
+ {{ range last 2 ($item := $data.documentation_runners) }}
+ <li><a href={{.name.link}}>{{ .name.text}}</a> {{ .description
| safeHTML }}</li>
Review comment:
It'd be great to use some hugo linter... if it exists. That would help
with consistency of formatting. Maybe we could even add linter check as a
precommit step?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
