lostluck commented on a change in pull request #13611: URL: https://github.com/apache/beam/pull/13611#discussion_r549457942
########## File path: sdks/go/pkg/beam/core/graph/coder/testutil/testutil.go ########## @@ -0,0 +1,136 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Package testutil contains helpers to test and validate custom Beam Schema coders. +package testutil + +import ( + "bytes" + "fmt" + "reflect" + "testing" + + "github.com/apache/beam/sdks/go/pkg/beam/core/graph/coder" + "github.com/google/go-cmp/cmp" +) + +// SchemaCoder helps validate custom schema coders. +type SchemaCoder struct { + encBldUT, encBldSchema coder.RowEncoderBuilder + decBldUT, decBldSchema coder.RowDecoderBuilder + + // CmpOptions to pass into the round trip comparison + CmpOptions cmp.Options +} + +// Register adds additional custom types not under test to both the under test +// and default schema coders. +func (v *SchemaCoder) Register(rt reflect.Type, encF, decF interface{}) { + v.encBldUT.Register(rt, encF) + v.encBldSchema.Register(rt, encF) + v.decBldUT.Register(rt, decF) + v.decBldSchema.Register(rt, decF) +} + +// Validate is a test utility to validate custom schema coders generate +// beam schema encoded bytes. +// +// Validate accepts the reflect.Type to register, factory functions for encoding and decoding, an +// anonymous struct type equivalent to the encoded format produced and consumed by the factory produced functions +// and test values. Values must be a single struct or pointer to struct. Review comment: Good call! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
