boyuanzz commented on a change in pull request #13630:
URL: https://github.com/apache/beam/pull/13630#discussion_r549880372
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/WindowingStrategyTranslationTest.java
##########
@@ -143,4 +162,142 @@ public void testToProtoAndBackWithComponents() throws
Exception {
proto.getAssignsToOneWindow(),
equalTo(windowingStrategy.getWindowFn().assignsToOneWindow()));
}
+
+ private static class CustomWindow extends IntervalWindow {
Review comment:
Just wondering are you going to add more tests around this
`CustomWindow` and `CustomWindowFn` below? It seems like if you only want to
test proto-object round trip, there is no need to construct so much details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
