iemejia commented on a change in pull request #13410: URL: https://github.com/apache/beam/pull/13410#discussion_r551198450
########## File path: sdks/java/build-tools/src/main/resources/beam/checkstyle.xml ########## @@ -119,6 +119,14 @@ page at http://checkstyle.sourceforge.net/config.html --> <property name="message" value="You are using raw guava, please use vendored guava classes."/> </module> + <!-- Forbid use of Charset.defaultCharset()--> + <module name="RegexpSinglelineJava"> + <property name="id" value="ForbidCharset"/> Review comment: nit: ultra minor (you can ignore me but good if changed) s/ForbidCharset/ForbidDefaultCharset ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
