TheNeuralBit commented on a change in pull request #13410:
URL: https://github.com/apache/beam/pull/13410#discussion_r552169007
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/JulHandlerPrintStreamAdapterFactory.java
##########
@@ -69,6 +69,9 @@
private int carryOverBytes;
private byte[] carryOverByteArray;
+ @SuppressWarnings({
+ "unchecked" // [BEAM-11327] Replace Charset.defaultCharset() with
StandardCharsets.UTF_8
Review comment:
It's concerning that the precommit didn't break when this was
suppressing the wrong warning. Have you seen the new checkstyle rule break
checkstyleMain or checkstyleTest?
I tried to get it to fail locally, but even with the SuppressWarnings
removed its not triggering on Charset.defaultCharset
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
