ihji commented on a change in pull request #13605:
URL: https://github.com/apache/beam/pull/13605#discussion_r552295607



##########
File path: 
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
##########
@@ -1342,6 +1347,57 @@ public void testTransformTranslator() throws IOException 
{
     assertTrue(transform.translated);
   }
 
+  @Test
+  public void testSdkHarnessConfiguration() throws IOException {

Review comment:
       The change applies to all existing ITs with use_runner_v2 flag (for 
example, runner v2 validate runner tests should fail if something goes wrong 
with this commit). Do you think we need a separate test only for this change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to