omarismail94 commented on a change in pull request #13410:
URL: https://github.com/apache/beam/pull/13410#discussion_r552375009
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/JulHandlerPrintStreamAdapterFactory.java
##########
@@ -69,6 +69,9 @@
private int carryOverBytes;
private byte[] carryOverByteArray;
+ @SuppressWarnings({
+ "unchecked" // [BEAM-11327] Replace Charset.defaultCharset() with
StandardCharsets.UTF_8
Review comment:
Aaaah, I finally found out what causes that. `checkstyleMain.enabled` is
set to `false` in the
[build.gradle](https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/build.gradle#L118)
for the worker project. I set it to `true`, then removed the
SuppressionWarning, and when I run `checkstyleMain`, I can see the rule gets
triggered. I also didn't know you can set the ID used as the label in,
`SuppressionWarning`, so I fixed that as well!
If you want to test, I think if you set the flag to `true` in the
build.gradle file, and remove the SuppressionWarning, then run the check, it
_should_ work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
