TheNeuralBit commented on a change in pull request #13701:
URL: https://github.com/apache/beam/pull/13701#discussion_r554057642
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingInitializer.java
##########
@@ -167,10 +168,10 @@ public static synchronized void initialize() {
originalStdErr = System.err;
System.setOut(
JulHandlerPrintStreamAdapterFactory.create(
- loggingHandler, SYSTEM_OUT_LOG_NAME, Level.INFO));
+ loggingHandler, SYSTEM_OUT_LOG_NAME, Level.INFO,
StandardCharsets.UTF_8));
System.setErr(
JulHandlerPrintStreamAdapterFactory.create(
- loggingHandler, SYSTEM_ERR_LOG_NAME, Level.SEVERE));
+ loggingHandler, SYSTEM_ERR_LOG_NAME, Level.SEVERE,
StandardCharsets.UTF_8));
Review comment:
The cases in this file are where we need `Charset.defaultCharset()`, not
UTF_8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
