nehsyc commented on a change in pull request #13496:
URL: https://github.com/apache/beam/pull/13496#discussion_r554123442
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryOptions.java
##########
@@ -78,4 +79,11 @@
Integer getLatencyLoggingFrequency();
void setLatencyLoggingFrequency(Integer value);
+
+ @Experimental
+ @Description("Whether dynamic sharding is enabled for writing to BigQuery in
streaming.")
+ @Default.Boolean(false)
+ Boolean getEnableStreamingAutoSharding();
Review comment:
I was thinking that adding the option to BigQueryOptions might be easier
for the users to switch on/off the feature. If it is an option of BigQueryIO
users would need to update their code (vs. adding a flag) right? It might not
be a concern...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
