runningcode commented on a change in pull request #13691:
URL: https://github.com/apache/beam/pull/13691#discussion_r554283508
##########
File path: sdks/java/core/build.gradle
##########
@@ -49,11 +49,11 @@ interface for processing virtually any size data. This
artifact includes entire Apache Beam Java SDK."""
processResources {
+ inputs.property('version', version)
+ inputs.property('sdk_version', sdk_version)
filter org.apache.tools.ant.filters.ReplaceTokens, tokens: [
'pom.version': version,
'pom.sdk_version': sdk_version,
- 'pom.docker_image_default_repo_root': docker_image_default_repo_root,
Review comment:
Good point. I added them to the sdk.properties and as inputs to the task.
##########
File path: sdks/java/core/src/main/resources/org/apache/beam/sdk/sdk.properties
##########
@@ -18,3 +18,5 @@
[email protected]@
[email protected]_version@
[email protected]_image_default_repo_root@
+docker_image_default_repo_prefix=@docker_image_default_repo_prefix@
Review comment:
Yeah, its important. It is used as the ReplaceToken in the build.gradle.
Its late here. zzz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
