je-ik commented on a change in pull request #13719:
URL: https://github.com/apache/beam/pull/13719#discussion_r555317940
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Trigger.java
##########
@@ -87,7 +88,7 @@ protected Trigger() {
}
public List<Trigger> subTriggers() {
- return subTriggers;
+ return MoreObjects.firstNonNull(subTriggers, Collections.emptyList());
Review comment:
I agree that it is questionable why the field should ever be null. On
the other hand, the code seems to distinguish cases when the field is null and
when the list is empty. This might be fixed later with other nullness related
fixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
